Working on SMF 'online character creator' - feedback welcome

[fergal]

If I build a character with another power that provides a re-roll, it will ad to it. If it is the only power providing a re-roll it comes up blank. I tried a street level with super agility and power blast and got no re-roll for melee defense or ranged defense.

Tried another street level with super agility and melee specialist and got 2 re-rolls in melee defense, but none in ranged defense!

Very strange

Kim

Aha, this makes me think I’ve got a spelling mistake in street level or super-agility.  Thanks, I’ll check it out tomorrow.

[fergal]

If I build a character with another power that provides a re-roll, it will ad to it. If it is the only power providing a re-roll it comes up blank. I tried a street level with super agility and power blast and got no re-roll for melee defense or ranged defense.

Tried another street level with super agility and melee specialist and got 2 re-rolls in melee defense, but none in ranged defense!

VERY WELL spotted!  The program is supposed to make sure that the re-roll stat is greater than zero, if it is then it prints it.  The program was checking the attack re-rolls correctly, but for the defense ones, it was checking to see if the attack re-roll was greater than 0, if it was then it was printing the defense re-roll stats.

It's all fixed now.  BUT if any characters were created up till now, you may be missing out on defense re-rolls!!!!

Might be good to test this out folks?

[kimryoung]

A few more bugs:

Power blasts minor puts a “0” in the melee defense re-roll box.

Boost "Tough" Does Not put the +1 re-roll in the melee defense box

Kim

[fergal]

A few more bugs:

Power blasts minor puts a “0” in the melee defense re-roll box.

Boost "Tough" Does Not put the +1 re-roll in the melee defense box

Kim

Here is a character that I created with only Power Blasts and Tough, everything seems to add up here. 



It's really helpful if you post the sheet with the mistakes so I can see all the powers selected and start the debug.  If you right click and 'copy image address' or whatever your browser says, that should let you paste the image into your dialog box on the forum.

[kimryoung]

Here is what I got:




http://rgregory11.pythonanywhere.com/static/hero_files/Kim_2018042523525966.png

[fergal]

OK, that is WICKED STRANGE.  I just recreated your bug, so now it's time to track it down.  This might take a bit as I'm not quite sure what's going on.  On my current machine, when I run it it works as expected.  Could be hard to track down....

[kimryoung]

I turned up a few more bugs:

Missing Jinx and Summoning on Wild card and Street level characters

Sorcerer allowing 2 minor power - should be only one

Giant selection not giving the +1 body addition.

Massive - notes not listing serve as mount or foes get +1 re-roll on melee/ranged attacks

Burrowing - notes not listing +1 re-roll vs body damaging attacks

Gadgets not showing 3D ranged attack in ranged attack box

Melee Specialist - option to take 2" reach instead of +1 re-roll on defense not given.

Thanks for the great effort on this project!

Kim

[fergal]

Thanks Kim.  I've got a final this week that I'm working on, BUT I will be getting to these bugs.  THANK YOU for taking the time to find them.  I'll address them one by one soon.

I'm going to spend an hour working on the earlier bugs now, hopefully I'll have a solution to them later tonight.

[fergal]

A few more bugs:

Power blasts minor puts a “0” in the melee defense re-roll box.

Boost "Tough" Does Not put the +1 re-roll in the melee defense box

Kim

Ok, I was able to reproduce this last week, but it seems to have resolved itself.  I can only think it was a caching issue.  BUT the good news is that it works as expected now.

[fergal]

Missing Jinx and Summoning on Wild card and Street level characters

Sorcerer allowing 2 minor power - should be only one

Giant selection not giving the +1 body addition.

Massive - notes not listing serve as mount or foes get +1 re-roll on melee/ranged attacks

Squashed all these, I'll upload the changes tonight.  The massive +1 for foes was there, but I did leave off the mounts stuff due to being really obscure. 

[fergal]

Burrowing - notes not listing +1 re-roll vs body damaging attacks

Gadgets not showing 3D ranged attack in ranged attack box

Melee Specialist - option to take 2" reach instead of +1 re-roll on defense not given.

Added burrowing notes, though I had left those off intentionally in the name of brevity.

Gadgets don't show the 3D ranged attacks because if you have another ranged power this will lower it.  I choose to add it in the notes as it's a fairly minor effect in the grand scheme of things.

Melee Specialist option was also left out as it's a minor option that didn't warrant the complications it would create to implement it.

[kimryoung]

Added burrowing notes, though I had left those off intentionally in the name of brevity.

Gadgets don't show the 3D ranged attacks because if you have another ranged power this will lower it.  I choose to add it in the notes as it's a fairly minor effect in the grand scheme of things.

Melee Specialist option was also left out as it's a minor option that didn't warrant the complications it would create to implement it.

Understand, that makes sense.

Any way to make notes go on to a second page rather than just cut them off? Some characters, particularly Supers and Powerhouses have lots of options that have lots of notes. If not perhaps you could just reference the page number in the rule book for easy finding.

Thanks again, you have done a great job!

Kim

[fergal]

I thought about notes on a separate sheet, but I wanted this to be an all in one thing.

It get's a bit crowded for Powerhouses and Sorcerers/Archers the most.  I can measure the number of lines of notes to print and if it's greater than X, decrease the font size to fit.  It's something I've been waiting on to see if it's getting used before I put the effort in as it's quite a lot of fiddling.  I think we are to the point of me putting it on the roadmap.

[kimryoung]

Smaller font might be problematical. I know some of us are already downsizing the print out and putting on 4 X 6 cards, so its already tough to read (especially in the gray font). If it rolled to a second page it could print on the back.

Getting the stat modifiers on the sheets is the main thing. Long drawn out notes for powers such as Save take up lots of space and referencing the rules page is probably more logical then duplicating this and other descriptively long powers.

Your point about "Brevity" is well taken, and perhaps its too much for some powers to get all the information listed.

Kim

[fergal]

Yeah, it's not meant to be a stand-in for the rulebook, just a way to help play the game without referencing it constantly.  More crib notes rather than unabridged volume.

Keep in mind, I'm not designing for a 4x6 print-out.  I'm designing for a half page printout, so that's really the only consideration that I'll keep in mind.  I asked quite a few times in the beginning (long before I started detailed work on the printed results) for feedback and suggestions and didn't get much input, so I went with what I wanted.