Yes an Uhlan. His tunic is called an Ulanka and the yellow piping corresponds to Uhlan Regts. 11, 15, 20, 21 (or guards with litzen). I believe Baron von Richtoffen wore an Ulanka as he was recruited to become a pilot from the cavalry, and so was entitled to wear the uniform of his original branch...